haskell / haskell/haskell-language-server

StylishHaskell shifting the working dir, this could lead to race condition

Open
#4,234 8 comments 1 reaction 0 assignees View on GitHub
component: formatters Hackathon priority: high type: bug
Dominant language
Haskell
Stars
3k
Forks
455
Avg merge
4d 3h
Merged PRs (30d)
12

Description

StylishHaskell shifting the working dir, it could make other part of hls depending on cwd result in error in some race condition.

https://github.com/haskell/haskell-language-server/blob/61fd5c464842448dfebe91d3e01de425eacf07b7/plugins/hls-stylish-haskell-plugin/src/Ide/Plugin/StylishHaskell.hs#L81

Such as `Hlint, Stan, Template haskel, session loader` etc. We should not shifting the working dir after initilization.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.