haskell / haskell/haskell-language-server

cannot rename implicit parameters

Open
#3,416 0 comments 0 reactions 1 assignee Claimed by @OliverMadine View on GitHub
component: hls-rename-plugin type: bug
Dominant language
Haskell
Stars
3k
Forks
455
Avg merge
3d 21h
Merged PRs (30d)
13

Description

If my cursor is over `?x` in the file below, a prompt can come up to rename `x`, but it doesn't change the file. I use hls 1.8
```
{-# LANGUAGE ImplicitParams #-}
a = let ?x = 3 in ?x
```
If you select a single `?x` to rename to `?y`, I see two options:
```
aa = (let ?x = 3 in ?x, let ?x = 2 in ?x) -- original
aa = (let ?y = 3 in ?y, let ?x = 2 in ?x) -- scoped rename
aa = (let ?y = 3 in ?y, let ?y = 2 in ?y) -- global rename
```
I would prefer "Scoped" for consistency with regular variables.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.