haskell / haskell/haskell-language-server

[Log of bugs] Folding range in hls-code-range-plugin

Open
#3,294 1 comment 0 reactions 0 assignees View on GitHub
component: hls-code-range-plugin type: bug
Dominant language
Haskell
Stars
3k
Forks
455
Avg merge
2d 19h
Merged PRs (30d)
11

Description

After adding the folding range feature in #3058, we found some minor bugs. If anyone has found any more bugs related to folding range, please note them down in this issue.

#### Here is the list of bugs/enhancements I could find:

- [ ] blank lines in between declaration and function create lots of weird folding ranges
#### Adding blank lines:
![image](https://user-images.githubusercontent.com/54478821/196092032-20026924-c616-4a34-91bd-9c7a6fde7812.png)
#### After folding any of the blank lines:
![image](https://user-images.githubusercontent.com/54478821/196092105-973742ba-9cee-4916-9e0b-0a5ab652a945.png)

#### Problems:
- Empty lines should not be folding range starts
- Blank lines between the function should not fold

- [ ] Deleting lines retains old folding ranges for some time till it refreshes

![image](https://user-images.githubusercontent.com/54478821/196092388-3d51f9cf-051a-4820-ba8e-76868528665a.png)
#### Problems:
- It should show correct folding ranges or no folding ranges till new folding ranges can be found

- [ ] Folding range does not interact with comments
#### Problems:
- Related to #3005

@michaelpj @kokobd Did you come across any other issues with folding ranges?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.