haskell / haskell/haskell-language-server

Consistent GHC ABI checking

Open
#2,720 2 comments 1 reaction 0 assignees View on GitHub
status: in discussion
Dominant language
Haskell
Stars
3k
Forks
455
Avg merge
4d 3h
Merged PRs (30d)
12

Description

Currently we do ABI checking here:

https://github.com/haskell/haskell-language-server/blob/f1e146b5a6409106d89241581d4f3ab755481e2d/bindist/wrapper.in#L65-L81

@wz1000 suggested this should maybe be done in haskell-language-server-wrapper binary directly. But @fendor noted that the logic to get GHC is actually in hie-bios and this PR is relevant: https://github.com/haskell/hie-bios/pull/282

So we probably want to check ABI in/via hie-bios.

----

Background:

* https://github.com/haskell/haskell-language-server/pull/2675
* https://gitlab.haskell.org/ghc/ghc/-/merge_requests/5965
* https://github.com/haskell/haskell-language-server/issues/2391

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.