haskell / haskell/hackage-server

Builder for candidates still needs work

Open
#949 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Haskell
Stars
467
Forks
225
PR merge metrics
No merged PRs in 30d

Description

These lines screw things up:

https://github.com/haskell/hackage-server/blob/4d6d2089d442859e3d04874a82f421cb8950eef5/exes/BuildClient.hs#L496

https://github.com/haskell/hackage-server/blob/4d6d2089d442859e3d04874a82f421cb8950eef5/exes/BuildClient.hs#L499

This looks up the package in the repoIndex. But for a candidate that _isn't_ a dup (i.e. for which that name/version pair is not yet in the main index) then of course the package won't be in the repoIndex yet!

So we need a different code path for candidates that entirely bypasses these lookups and handles candidates specially/directly.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.