haskell / haskell/containers

Data.Sequence sort functions should be able to inline to eliminate unknown calls.

Open
#799 2 comments 0 reactions 0 assignees View on GitHub
performance Seq
Dominant language
Haskell
Stars
355
Forks
194
Avg merge
3d 4h
Merged PRs (30d)
4

Description

I'm looking at containers for container-unrelated reasons.

I noticed that some of the sort-related functions (e.g. `popMinQ`) don't have unfoldings available.
This means all comparisons will have to be made by performing unknown calls - yikes.

This extends from `popMinQ` to sort, sortBy at least (and perhaps all the stable sorts).

Now `popMinQ` isn'T small at all at ~400 terms. But I imagine for most use cases it would be beneficial to inline this in order to eliminate the unknown call.

I'm not sure how to best achieve this, but it seems reasonable to me.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.