haskell / haskell/cabal

testsuite: skipifVersion "9.6.3" in VersionPriority tests looks overfitted

Open
#9,738 6 comments 0 reactions 0 assignees View on GitHub
needs triage type: bug
Dominant language
Haskell
Stars
1.7k
Forks
750
Avg merge
4d 3h
Merged PRs (30d)
28

Description

The `VersionPriority` tests have code along the lines of

```
8832b2689a (Phil de Joux 2023-12-31 08:52:34 -0500 11) skipIfGhcVersion "== 9.6.3"
````

but the reason seems to be an unrelated bug in the testsuite:

```
8832b2689a (Phil de Joux 2023-12-31 08:52:34 -0500 8) -- To avoid this diff:
8832b2689a (Phil de Joux 2023-12-31 08:52:34 -0500 9) -- -Build profile: -w ghc-9.6.3 -O1
8832b2689a (Phil de Joux 2023-12-31 08:52:34 -0500 10) -- +Build profile: -w ghc- -O1
```

This kind of bug happens in situations where you build `cabal-tests` with a different `ghc` version to the one on your path I think, in any case, that is the bug which should be fixed rather than workarounds which only apply to very specific cases in the testsuite.

cc @philderbeast

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.