haskell / haskell/cabal

Rename BuildOutcomes

Open
#6,710 0 comments 0 reactions 0 assignees View on GitHub
type: refactor
Dominant language
Haskell
Stars
1.7k
Forks
750
Avg merge
4d 3h
Merged PRs (30d)
28

Description

```
Ambiguous occurrence ‘BuildOutcomes’
It could refer to
either ‘Distribution.Client.ProjectBuilding.BuildOutcomes’,
imported from ‘Distribution.Client.ProjectBuilding’ at tests/IntegrationTests2.hs:23:1-42
(and originally defined in ‘Distribution.Client.ProjectBuilding.Types’)
or ‘Distribution.Client.InstallPlan.BuildOutcomes’,
imported from ‘Distribution.Client.InstallPlan’ at tests/IntegrationTests2.hs:73:1-38
```

This is terrible.

If there are other types (as there are) which share the same name, those have to be renamed too. This kind of surprises kill any flow you might have.

Contributor guide

Open the contributing guide

Research direction

Start with the ambiguous imports in tests/IntegrationTests2.hs, then inspect the BuildOutcomes definitions in Distribution.Client.ProjectBuilding.Types and Distribution.Client.InstallPlan. Identify the other same-named types and their references. Done means the conflicting names are distinct and the affected tests compile without an ambiguous occurrence.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.