haskell / haskell/cabal

Accept + in PkgconfigVersion

Open
#6,539 5 comments 0 reactions 0 assignees View on GitHub
Cabal: file format re: pkg-config type: enhancement
Dominant language
Haskell
Stars
1.7k
Forks
750
Avg merge
4d 3h
Merged PRs (30d)
28

Description

See https://github.com/haskell/cabal/issues/163#issuecomment-585826788

Currently we have

```haskell
instance Parsec PkgconfigVersion where
parsec = PkgconfigVersion . BS8.pack <$> P.munch1 predicate where
predicate c = isAsciiAlphaNum c || c == '.' || c == '-'
```

But I *think* we can accept all non-space, non-comma and non `&|<=>` characters. (Technically we can accept also `&|<=>`, but then the space will be required between the "version range operators" and version) Yet it would be really nice if there were some reference what kind of characters are used out there; underspecification of what pkg-config accepts / recommends is not nice, as we need to be able to combine these version strings into larger grammars

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.