haskell / haskell/cabal

Remove `fromFlag`.

Open
#5,894 1 comment 2 reactions 0 assignees View on GitHub
type: refactor
Dominant language
Haskell
Stars
1.7k
Forks
750
Avg merge
4d 3h
Merged PRs (30d)
28

Description

It's essentially `fromJust`, and makes everyone think "is this safe, why it's safe". Also in many cases its safety isn't asserted with a comment.

Maybe we need `UncondFlag` without a "`Nothing`" branch, but I'd be in favour of adding that type, if it's what we need.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.