haskell / haskell/cabal

Don't implement allow-newer/allow-older by modifying PackageDescription

Open
#4,203 10 comments 5 reactions 0 assignees View on GitHub
cabal-install: solver re: allow-newer type: enhancement type: refactor
Dominant language
Haskell
Stars
1.7k
Forks
750
Avg merge
4d 3h
Merged PRs (30d)
28

Description

It seems cleaner to hook it straight into the dep solver, rather than try to ninja it in by package description modification. If you do it by modification, you have to worry about making sure the "correct" package description is used anywhere you want to look at deps, and sometimes you get spurious warnings because it looks like you modify build-depends which affects our source level checks, but actually we didn't.

The lack of cleanliness here is hurting me because I want BuildInfo to reflect the written syntax as closely as possible (when I make the modification for #4155), but I have to keep `targetBuildDepends` around as a real field if people are editing it.

Previously @kosmikus requested this in #3466.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.