haskell / haskell/cabal

PowerShell transport always returns 200 in case of success

Open
#3,388 1 comment 0 reactions 0 assignees View on GitHub
cabal-install: other re: http-transport type: bug
Dominant language
Haskell
Stars
1.7k
Forks
750
Avg merge
4d 3h
Merged PRs (30d)
28

Description

In `D.C.Security.HTTP` we have the following code:

```
200 -> callback HttpStatus200OK respHeaders br
206 -> callback HttpStatus206PartialContent respHeaders br
```

However, the PowerShell transport always returns code 200 in case of success, which will cause the wrong callback to be invoked when the actual response code is 206.

Additionally, the PowerShell transport always returns `Nothing` as etag.

/cc @edsko, @gbaz

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.