haskell / haskell/cabal

Duplicated mkVerbosity from handles and setupVerbosity

Open
#11,777 0 comments 0 reactions 0 assignees View on GitHub
type: refactor
Dominant language
Haskell
Stars
1.7k
Forks
750
Avg merge
4d 3h
Merged PRs (30d)
28

Description

While reviewing #11767, I noticed that we have a lot of repetitions of the following (and others similar):

https://github.com/haskell/cabal/blob/e6ff0ccf6f2761f1d3d82b4383b053c21f816e27/Cabal/src/Distribution/Simple/Configure.hs#L1163-L1164

Could we reduce this repetition?

```
$ grep -E 'mkVerbosity verbHandles.*setupVerbosity' **/*.hs
Cabal/src/Distribution/Simple.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity commonFlags')
Cabal/src/Distribution/Simple.hs: let verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity commonFlags)
Cabal/src/Distribution/Simple.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple.hs: verbosity = mkVerbosity verbHandles $ fromFlag (setupVerbosity $ sDistCommonFlags flags)
Cabal/src/Distribution/Simple.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple.hs: verbosity = mkVerbosity verbHandles (fromFlag (setupVerbosity common))
Cabal/src/Distribution/Simple/Configure.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple/Configure.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple/Configure.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple/Configure.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple/Configure.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple/Configure.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple/Configure.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple/ConfigureScript.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity commonCfg)
Cabal/src/Distribution/Simple/GHC/Build/Link.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple/Haddock.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple/Install.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple/Register.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple/Register.hs: verbosity = mkVerbosity verbHandles (fromFlag (setupVerbosity common))
Cabal/src/Distribution/Simple/Register.hs: verbosity = mkVerbosity verbHandles (fromFlag (setupVerbosity common))
Cabal/src/Distribution/Simple/SrcDist.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple/Test.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
Cabal/src/Distribution/Simple/Test/ExeV10.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity commonFlags)
Cabal/src/Distribution/Simple/Test/LibV09.hs: verbosity = mkVerbosity verbHandles (fromFlag $ setupVerbosity common)
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.