haskell / haskell/bytestring

Remove strict aliasing violations from our C code

Open
#594 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
301
Forks
144
Avg merge
7d 22h
Merged PRs (30d)
1

Description

Although we've enabled `-fno-strict-aliasing` in #582, I would on principle rather we just didn't have any strict-aliasing violations in our code. But:
* I expect the `bytestring` C code contains little (if any) of the sort of code that actually gets performance wins from `-fstrict-aliasing`
* Although the strict-aliasing-compliant idioms are not uglier than what we are currently doing instead, they are not prettier in any way except that they remove the need to remember that `-fno-strict-aliasing` has been set.

So this is an extremely-low-priority task.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by inspecting the bytestring C code and the -fno-strict-aliasing change referenced in issue #582. Identify every strict-aliasing violation and replace them with compliant idioms; the work is done when the C code no longer requires those violations.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, haskell
Domain
performance
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.