haskell / haskell/attoparsec

notInClass seems to handle UTF-8 needlessly

Open
#152 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
531
Forks
98
PR merge metrics
No merged PRs in 30d

Description

https://hackage.haskell.org/package/attoparsec-0.13.2.2/docs/Data-Attoparsec-ByteString.html#v:notInClass

When looking at core i saw the following:

```
(notInClass
(ghc-prim-0.5.3:GHC.CString.unpackCStringUtf8#
"some string here"#)
w_a3cX)
```

The `unpackCStringUtf8` is not in `notInClass` itself, but seems to be the result from `notInClass` using `String` as input. Also i doubt whether a list type like String is the best choice here.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.