haskell-servant / haskell-servant/servant-js

Query parameters and Headers should not be added to the generated request if they are `undefined`

Open
#16 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
Haskell
Stars
23
Forks
22
PR merge metrics
No merged PRs in 30d

Description

In Servant the `QueryParam` adds its parameter as a `Maybe` type because query parameters and headers are optional. However, it seems like the vanilla JS generated code _always_ appends the parameters even if undefined.

I think it's a good idea if the generated JS checks for undefined query parameters and headers and appropriately omits them from the URL.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.