haskell-prettyprinter / haskell-prettyprinter/prettyprinter

`prettyprinter-compat-ansi-wl-pprint ` is not quite a drop-in replacement as claimed

Open
#246 2 comments 1 reaction 0 assignees View on GitHub
Documentation
Dominant language
Haskell
Stars
309
Forks
43
Avg merge
21h 25m
Merged PRs (30d)
1

Description

This was noticed in https://github.com/ekmett/ansi-wl-pprint/pull/32#issue-1712218860, but I've found some other incompatibilities:

- There's no `Pretty a => Pretty (Maybe a)` instance, which old code may rely on.
- We have `Doc = Doc AnsiStyle`, which means that any existing `Pretty` instances which use basic functions like [`text`](https://hackage.haskell.org/package/ansi-wl-pprint-1.0.2/docs/Text-PrettyPrint-ANSI-Leijen.html#v:text) no longer compile, since `prettyprinter`'s `pretty` has to be annotation-polymorphic.

These are not easily solved, so I think the README ought to just be clearer about the limitations.

This has caused issues for some `ansi-wl-pprint`-dependent packages, such as `tmp-postgres`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.