hashmapinc / hashmapinc/Drillflow
DEV:FsR:GetFromStore - unused payload need to be removed
- Dominant language
- Java
- Stars
- 21
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Description
In getObject() within DotDelegator.java, you have the following unused code:
// get object as payload string
String payload;
if ("1.4.1.1".equals(witsmlObject.getVersion())) {
payload = witsmlObject.getJSONString("1.4.1.1");
} else {
payload = witsmlObject.getJSONString("1.3.1.1");
}
payload = JsonUtil.removeEmpties(new JSONObject(payload));
First, this is wrong code (even if the payload was being used) because when you send information over to DoT, you MUST speak 2.0.
Second, the payload is NOT used (so it is confusingly wrong that it is there).
Please remove this code and be sure that when you exchange information from DoT, you realize that you may have a 1.3.1.1/1.4.1.1/2.0 Client talking to a 2.0 DoT application. Going in the reverse direction, it is always 2.0 DoT application returning to your 1.3.1.1/1.4.1.1/2.0 Client.
For an example of how you would create a 2.0 Payload, please refer to AddToStore.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.