hashmapinc / hashmapinc/Drillflow

DEV:LOG: getWellName & getWellBoreName searches allow a Status of 400

Open
#633 1 comment 0 reactions 1 assignee Claimed by @TessForGithub2 View on GitHub
API bug
Dominant language
Java
Stars
21
Forks
13
PR merge metrics
No merged PRs in 30d

Description

getWellName in LogConverterExtended.java (Valve) has this code:
int status = response.getStatus();
// If there is an error, well name will return as NULL.
if (201 == status || 200 == status || 400 == status) {
// get the wellborename of the first wellbore in the response
wellName = GraphQLRespConverter.getWellNameFromGraphqlResponse(new JSONObject(response.getBody()));

// cache the wellbore uuid/uid
//UidUuidCache.putInCache(wellName, witsmlObject.getParentUid(), witsmlObject.getGrandParentUid());

}
Error -> The logic should only allow 201 or 200 to continue the logic flow. Otherwise, this will bomb on "response.getBody.

Also fixing getWellBoreName for the same reason.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.