hashmapinc / hashmapinc/Drillflow

DEV:LOG:Witsml Response Assumes 1.4.1.1 Response to Client

Open
#467 4 comments 0 reactions 2 assignees Claimed by @sukhendumukherjee View on GitHub
API bug Deliverable
Dominant language
Java
Stars
21
Forks
13
PR merge metrics
No merged PRs in 30d

Description

Associated card: #454

Originally, card 454 assumed the "fix" required was just in Channel.java. While testing this fix, it was discovered that the following areas of code assumed that the Witsml Response was only 1.4.1.1:
1. LogConverterExtended.java
2. DotDelegator (return finalResponse.getJSONString("1.4.1.1") in getFromStoreRestCalls
3. Need to check elsewhere about this assumption

These errors are due to not understanding that:
1. DoT speaks 1.4.1.1. for well and wellbore and trajectory REST
2. DoT speaks 2.0 for Trajectory graphql
3. DoT speaks 2.0ish for log

So, for log, the response will be 2.0ish ALWAYS.
However, the original request could have been 1.3.1.1 or 1.4.1.1 (which is essentially 2.0ish).
So returning a response as just 1.4.1.1 is incorrect.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.