hashicorp / hashicorp/vault

Missing request ID in audit entries for help requests

Open
#32,026 0 comments 1 reaction 0 assignees View on GitHub
bug core/audit
Dominant language
Go
Stars
36.3k
Forks
4.8k
PR merge metrics
PR metrics pending

Description

**Describe the bug**
Audit entries for e.g. `vault path-help` don't have a `request.id` set.
This throws of code trying to match responses to requests

**To Reproduce**
Steps to reproduce the behavior:
1. Enable audit logging
2. Run `vault path-help sys/policies/acl`
3. Inspect created audit entry

**Expected behavior**
All logs should have that ID set

**Environment:**
* Vault Server Version (retrieve with `vault status`): Vault 1.20.0
* Vault CLI Version (retrieve with `vault version`): Vault v1.21.4

Contributor guide

Open the contributing guide

Research direction

Start by enabling audit logging and running `vault path-help sys/policies/acl` against Vault 1.20.0 with the CLI version noted in the issue, then inspect the resulting audit entry and trace the help-request path into the Go audit code. Done means audit entries produced by help requests include a usable `request.id` so responses can be matched to requests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.