hashicorp / hashicorp/vault-ssh-helper

"make updatedeps" failing

Open
#62 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
446
Forks
56
PR merge metrics
No merged PRs in 30d

Description

Platform: macOS 12.2.1, go version go1.17.6 darwin/amd64

I'm not sure whether this is fundamentally a problem with vault-ssh-helper or one of its upstream go libraries (and if so which one), so I thought I'd raise it here first.

$ make updatedeps
GO111MODULE=off go get -u github.com/mitchellh/gox
echo $(go list ./... | grep -v /vendor/) \
		| xargs go list -f '{{ join .Deps "\n" }}{{ printf "\n" }}{{ join .TestImports "\n" }}' \
		| grep -v github.com/hashicorp/vault-ssh-helper \
		| xargs go get -f -u -v
go get: -f flag is a no-op when using modules
go: downloading github.com/fatih/color v1.13.0
go: downloading github.com/hashicorp/errwrap v1.1.0
go: downloading github.com/hashicorp/go-cleanhttp v0.5.2
go: downloading github.com/golang/snappy v0.0.4
go: downloading github.com/hashicorp/go-multierror v1.1.1
go: downloading github.com/hashicorp/go-rootcerts v1.0.2
go: downloading github.com/hashicorp/go-retryablehttp v0.7.0
go: downloading github.com/hashicorp/go-hclog v1.1.0
go: downloading github.com/hashicorp/go-sockaddr v1.0.2
go: downloading github.com/hashicorp/go-uuid v1.0.2
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/hashicorp/vault/api v1.3.1
go: downloading github.com/hashicorp/vault v1.9.3
go: downloading github.com/hashicorp/vault/sdk v0.3.0
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/mattn/go-colorable v0.1.12
go: downloading github.com/mattn/go-isatty v0.0.14
go: downloading github.com/mitchellh/mapstructure v1.4.3
go: downloading github.com/ryanuber/go-glob v1.0.0
go: downloading golang.org/x/crypto v0.0.0-20220214200702-86341886e292
go: downloading github.com/pierrec/lz4 v2.6.1+incompatible
go: downloading golang.org/x/net v0.0.0-20220127200216-cd36cc0744dd
go: downloading golang.org/x/text v0.3.7
go: downloading gopkg.in/square/go-jose.v2 v2.6.0
go: downloading golang.org/x/time v0.0.0-20220210224613-90d013bbcef8
go get: module golang.org/x/crypto@upgrade found (v0.0.0-20220214200702-86341886e292), but does not contain package golang.org/x/crypto/ed25519/internal/edwards25519
go get: module golang.org/x/crypto@upgrade found (v0.0.0-20220214200702-86341886e292), but does not contain package golang.org/x/crypto/ed25519/internal/edwards25519
make: *** [updatedeps] Error 1

I get the same error on an Ubuntu system, go version go1.16.6 linux/amd64.

I note that go.mod references github.com/hashicorp/vault/api v1.0.5-0.20200608151603-eb666e94bdb4,but

go get github.com/hashicorp/vault/api@v1.0.5-0.20200608151603-eb666e94bdb4

works without errors. So does this:

$ go mod vendor
go: downloading github.com/hashicorp/vault/api v1.0.5-0.20200608151603-eb666e94bdb4
go: downloading github.com/hashicorp/errwrap v1.0.0
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading github.com/hashicorp/go-multierror v1.0.0
go: downloading github.com/hashicorp/go-retryablehttp v0.6.2
go: downloading github.com/hashicorp/go-rootcerts v1.0.1
go: downloading github.com/hashicorp/vault/sdk v0.1.14-0.20200514144402-4bfac290c352
go: downloading github.com/mitchellh/mapstructure v1.2.2
go: downloading gopkg.in/square/go-jose.v2 v2.3.1
go: downloading github.com/hashicorp/go-hclog v0.12.0
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/fatih/color v1.7.0
go: downloading github.com/mattn/go-colorable v0.1.4
go: downloading github.com/mattn/go-isatty v0.0.10
go: downloading github.com/pierrec/lz4 v2.0.5+incompatible
go: downloading github.com/golang/snappy v0.0.1
go: downloading golang.org/x/text v0.3.1-0.20181227161524-e6919f6577db
go: downloading golang.org/x/crypto v0.0.0-20190418165655-df01cb2cc480
go: downloading golang.org/x/sys v0.0.0-20191008105621-543471e840be
$

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the updatedeps target in the Makefile and compare its behavior with the versions pinned in go.mod. Reproduce the failure with make updatedeps, then compare it with go get for the Vault API version and go mod vendor, as shown in the report. Done means the dependency-update target completes successfully without the x/crypto/ed25519/internal/edwards25519 error.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.