hashicorp / hashicorp/vault-secrets-operator

Add ability to ignore certain labels/annotations (or only check relevant ones)

Open
#839 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
Go
Stars
600
Forks
146
Avg merge
3d 8h
Merged PRs (30d)
6

Description

**Describe the bug**
A clear and concise description of what the bug is.

As of https://github.com/hashicorp/vault-secrets-operator/pull/576, it seems like _any_ label/annotation change is causing our dynamic secrets to roll and trigger a rollout restart for the affected rollable objects. We should either add an exclude list of labels/annotations that _won't_ trigger a reconcile, or we should only be checking relevant labels/annotations in `labelChangedPredicate` and `annotationChangedPredicate`.

**To Reproduce**
Steps to reproduce the behavior:
1. Change any annotation on a `VaultDynamicSecret`
2. See a rollout restart trigger

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the labelChangedPredicate and annotationChangedPredicate entry points implicated in the issue, then reproduce the behavior by changing an annotation on a VaultDynamicSecret. Done means irrelevant label or annotation changes no longer trigger a reconcile or rollout restart, while relevant changes still do.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
devops, infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.