hashicorp / hashicorp/vault-secrets-operator

Do not Trigger RolloutRestart with every secret change

Open
#644 3 comments 4 reactions 1 assignee Claimed by @benashz View on GitHub
batch-rollout-restarts enhancement
Dominant language
Go
Stars
600
Forks
146
Avg merge
3d 8h
Merged PRs (30d)
6

Description

The RolloutRestart feature is a great feature of the operator.
However, the current implementation can cause outages or service degradation if several secrets are rotated for a given application within a short interval. This would set off a series of "thrashing" restarts.

Could we add a feature to "batch" up restarts for a given target ?
This way it would ensure only 1 rolling restart is executed within that period - eliminating unnecessary pod restarts.

eg the following would do a max of one rolling restart for the " vso-db-demo" deployment per hour.
rolloutRestartTargets:
- kind: Deployment
name: vso-db-demo
deployInterval: "60m"

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.