hashicorp / hashicorp/vault-helm
Vault Injector PDB is installed when Injector is not enabled
- Dominant language
- Shell
- Stars
- 1.3k
- Forks
- 898
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 1
Description
**Describe the bug**
Injector PDB is installed when the injector is disabled
**To Reproduce**
Steps to reproduce the behavior:
1. Install chart
2. Set a PDB
3. Set Injector.enabled: false
**Expected behavior**
Nothing should be installed
**Environment**
* Kubernetes version: 1.21
* Distribution or cloud vendor (OpenShift, EKS, GKE, AKS, etc.): EKS
* Other configuration options or runtime services (istio, etc.):
* vault-helm version: 0.22.0
Chart values:
```yaml
values: |
global:
enabled: false
injector:
enabled: false
podDisruptionBudget:
maxUnavailable: 1
```
Contributor guide
Research direction
Start by rendering the vault-helm chart with injector.enabled=false and injector.podDisruptionBudget.maxUnavailable=1, then inspect the rendered injector PodDisruptionBudget template. The fix is complete when no injector PDB is rendered while the injector is disabled, without changing the enabled case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, kubernetes
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100