hashicorp / hashicorp/serf

Reference implementation of RPC client interface doesn't have correct queryRecord struct

Open
#363 1 comment 0 reactions 0 assignees View on GitHub
bug straightforward
Dominant language
Go
Stars
6.1k
Forks
609
Avg merge
15h 1m
Merged PRs (30d)
3

Description

Noticed this while working on a C++ implementation of the serf RPC interface. Per the documentation, the queryRecord has the following content:

```
{"Seq": 50, "Error": ""}
{
"Event": "query",
"ID": 1023,
"LTime": 125,
"Name": "load",
"Payload": "15m",
}
```

The go implementation of queryRecord (https://github.com/hashicorp/serf/blob/master/client/const.go#L157) appears to be incorrect:

```
type queryRecord struct {
Type string
From string
Payload []byte
}
```

In my C++ implementation I've verified that the struct sent by the serf agent has these fields.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.