hashicorp / hashicorp/packer-plugin-sdk

Make `iso_file` more configurable

Open
#119 0 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
Go
Stars
42
Forks
62
Avg merge
29m
Merged PRs (30d)
2

Description

#### Community Note
Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request.
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request.
If you are interested in working on this issue or have submitted a pull request, please leave a comment.

#### Description
When creating a VM, I can specify `iso_file` but no other configuration e.g. `device`. I can, however, specify this if I use the `additional_iso_files` array. The issue is that `iso_file` is mandatory, but does not let me configure it correctly.

#### Use Case(s)
My specific setup is running Proxmox on a Raspberry Pi. The issue I have is that the ISO has to be a `scsi` device, but the required `iso_file` attaches it as `ide`.

#### Potential configuration
I can see three potential ways that this could be fixed (this is not exhaustive, I'm sure there are other solutions):
1. Make `iso_file`* optional
- Would avoid breaking existing configurations that people have
2. Make `iso_file`* optional with `additional_iso_files` i.e. require one of them
- I think this would be the best option, as it won't break people's current configurations
3. Remove `iso_file`* and use `additional_iso_files`
- I think this would be the ideal solution as I don't really understand why the first ISO is treated special instead of just part of the list of ISOs, but would probably break a lot of exisiting configurations
- It would also probably make sense for `additional_iso_files` to be renamed to `iso_files` in this case

\* When I say `iso_file` I am also referring to the other fields that accompany it e.g. `iso_url`, `iso_storage_pool`, `iso_checksum`

#### Potential References
Documentation for [`iso_file`](https://www.packer.io/plugins/builders/proxmox/iso#iso_file)
Documentation for [`additional_iso_files`](https://www.packer.io/plugins/builders/proxmox/iso#additional_iso_files)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.