hashicorp / hashicorp/nomad

UI: Unify how we detect abort errors

Open
#9,944 0 comments 0 reactions 0 assignees View on GitHub
theme/ui type/tech-debt
Dominant language
Go
Stars
17k
Forks
2.1k
Avg merge
1d 9h
Merged PRs (30d)
105

Description

As part of the Ember 3.20 and related dependency upgrades, the existing `error instanceof AbortError` check became insufficient.

With some research, I think we can find a new way to handle this issue with a single conditional.

https://github.com/hashicorp/nomad/blob/4e0e33e7c0bfbf48b4729d3b02950b9ced7edb06/ui/app/adapters/watchable.js#L58-L68

Introduced in #9912

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with ui/app/adapters/watchable.js at lines 58-68 and review how abort errors are currently detected after the Ember 3.20 and dependency upgrades. Identify a single conditional that handles the affected abort errors, then verify the behavior with the relevant UI tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.