hashicorp / hashicorp/nomad

Update agent pprof rpcs to streaming

Open
#6,933 0 comments 0 reactions 0 assignees View on GitHub
theme/performance type/enhancement
Dominant language
Go
Stars
17k
Forks
2.1k
Avg merge
1d 9h
Merged PRs (30d)
105

Description

### Issue

Improve upon #6841 to use streaming rpc endpoints so that the entire profile isn't loaded into memory. On a buys client or server a long run trace profile can reach near 100mb. Streaming would alleviate some of the memory burden on the server instead of loading it entirely in memory.

See https://github.com/hashicorp/nomad/pull/6841#issuecomment-572731049 for memory characteristics of various profiles.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the agent pprof RPCs and the prior work in issue #6841, including its linked discussion about profile memory characteristics. The work is complete when long-running trace profiles use streaming RPC endpoints rather than loading the entire profile into memory.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, observability
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.