hashicorp / hashicorp/nomad

merge RPC endpoint tests with ACLs disabled

Open
#18,756 0 comments 0 reactions 0 assignees View on GitHub
theme/auth theme/tech-debt theme/testing
Dominant language
Go
Stars
17k
Forks
2.1k
Avg merge
1d 9h
Merged PRs (30d)
105

Description

As a follow-up to the "No Nil ACLs" work (ref https://github.com/hashicorp/nomad/pull/18754), we can safely eliminate separate testing code paths for when ACLs are disabled and just have ACLs enabled on all RPC endpoint tests. This will greatly reduce the amount of test code we have to write.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading the RPC endpoint tests and the linked “No Nil ACLs” pull request (#18754) to understand the existing ACL-disabled paths. The work is complete when RPC endpoint tests consistently run with ACLs enabled and the separate disabled-ACL testing code paths are removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.