hashicorp / hashicorp/nomad

update `api.Allocations.Stop` signature to use `WriteOptions`

Open
#18,384 1 comment 0 reactions 0 assignees View on GitHub
hcc/jira stage/accepted theme/allocation API theme/api theme/docs
Dominant language
Go
Stars
17k
Forks
2.1k
Avg merge
1d 9h
Merged PRs (30d)
105

Description

https://github.com/hashicorp/nomad/blob/290a310544f70a9727643eefb856f6d5d0150fdf/api/allocations.go#L189

The docs reference a change in the function signature for stopping allocations starting in Nomad 1.6.0-- I'm on 1.6.0 and the old signature is still used.

Contributor guide

No contributing guide indexed for this repository

Research direction

Open api/allocations.go at the linked line and inspect api.Allocations.Stop against the documented Nomad 1.6.0 signature. Done means the Stop signature uses WriteOptions and the implementation and documentation agree; check the surrounding API context before making the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
40/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.