hashicorp / hashicorp/nomad

cleanup: rename Equals to Equal

Open
#14,698 0 comments 0 reactions 0 assignees View on GitHub
theme/cleanup
Dominant language
Go
Stars
17k
Forks
2.1k
Avg merge
1d 9h
Merged PRs (30d)
105

Description

tl;dr `s/Equals(/Equal(/g`

Much of Nomad's code predates Go convention, including our `Equals` methods. It seems `Equal` (no s) is becoming the norm.

e.g. https://pkg.go.dev/golang.org/x/exp/maps#Equal

Let's update Nomad to follow the convention.

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the repository for Equals method declarations and calls, then review the affected Go packages to confirm the rename is consistent. Update every occurrence to Equal and run the affected Go tests; done means no intended Equals methods or calls remain and the tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.