cleanup: refactor "unit_test.go" Consul integration tests into proper e2e/unit tests
- Dominant language
- Go
- Stars
- 17k
- Forks
- 2.1k
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 105
Description
In https://github.com/hashicorp/nomad/pull/14546 we're removing a chunk of Consul integration testing out of the unit tests - these tests are _extremely_ invasive on implementation details of various components of Nomad's wrapper around Consul. Well written tests do not do this - instead functions should be tested individually, the whole integration should be covered in e2e testing.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reviewing unit_test.go and the Consul integration tests it contains, then read the referenced pull request #14546 for the tests already being removed. Separate individual function coverage from whole-integration coverage, placing the former in unit tests and the latter in e2e tests; done means the invasive integration cases no longer remain in unit_test.go.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100