hashicorp / hashicorp/nomad

metrics: rename ACL metrics to use underscore naming

Open
#13,736 0 comments 0 reactions 0 assignees View on GitHub
stage/accepted theme/metrics type/bug
Dominant language
Go
Stars
17k
Forks
2.1k
Avg merge
1d 9h
Merged PRs (30d)
105

Description

The [`nomad.acl.resolveToken`](https://github.com/hashicorp/nomad/blob/6e0eb786f91f2bb052d867f227d4fbae8ee37e03/nomad/acl.go#L21) and [`nomad.acl.resolveSecretToken`](https://github.com/hashicorp/nomad/blob/6e0eb786f91f2bb052d867f227d4fbae8ee37e03/nomad/acl.go#L144) metrics are the only metrics that use camel case naming, rather than separating words using underscore.

It would be nice to update these, or add new ones while deprecating these, which follow the normal naming standard within Nomad.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in nomad/acl.go at the resolveToken and resolveSecretToken metric definitions linked in the issue. Check nearby metric conventions and any relevant tests or documentation, then determine whether the existing names should be renamed or deprecated in favor of underscore-separated names. Done means both ACL metrics follow Nomad's naming standard with compatibility behavior decided and verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.