hashicorp / hashicorp/mdns

Respond TXT record even if TXT field is nil

Open
#114 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
1.4k
Forks
225
Avg merge
15h 34m
Merged PRs (30d)
3

Description

Hello,

It responds TXT Record even if the TXT field of MDNSService is nil here https://github.com/hashicorp/mdns/blob/main/zone.go#L305
But I think it'd be better if it responded nothing when it received TXT query and the TXT field is nil.

Any suggestions or thoughts would be appreciated.

Contributor guide

Open the contributing guide

Research direction

Start at zone.go around line 305 and trace how TXT queries are handled when MDNSService.TXT is nil. Confirm the current response behavior, then make the behavior match the issue's requested outcome: no response to a TXT query when the TXT field is nil.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.