hashicorp / hashicorp/go-retryablehttp

Reason behind closing all idle connections aggresively

Open
#237 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
2.3k
Forks
298
PR merge metrics
No merged PRs in 30d

Description

Hey,
I was trying to understand the flow of `Do` function and noticed that all idle connections are being closed if we are not able to read the request body or if all retries are exhausted and we still have an error.

Can't we selectively close the current connection that is causing problems rather than closing all the good connections that can be reused for subsequent requests to the same host.

I am trying to understand the reasoning behind this as we are going to integrate this lib in production service with a high throughput and I am uncomfortable with the impact of closing idle connections.

TIA for helping me out.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.