hashicorp / hashicorp/go-retryablehttp

Platform specific regex pattern question

Open
#234 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
2.3k
Forks
298
PR merge metrics
No merged PRs in 30d

Description

Hello! I'm wondering about something and would like to ask some help/verification.
So, in the client there is a regex pattern which validates against errors caused by untrusted certificates. https://github.com/hashicorp/go-retryablehttp/blob/40b0cad1633fd521cee5884724fcf03d039aaf3f/client.go#L86

However, in the Go source code I see the following
```go
macosErr: "x509: “valid.testing.golang.invalid” certificate is not trusted",
windowsErr: "x509: certificate signed by unknown authority",
```
[source](https://github.com/golang/go/blob/aeac0b6cbfb42bc9c9301913a191bb09454d316a/src/crypto/x509/platform_test.go#L171)
Does this mean there should be a different, platform specific regex pattern for Windows?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.