hashicorp / hashicorp/go-retryablehttp
baseRetryPolicy not closing response
Open
- Dominant language
- Go
- Stars
- 2.3k
- Forks
- 298
- PR merge metrics
- No merged PRs in 30d
Description
I noticed in the docs for the CheckRetry function that its responsible for closing the response if the function determines retry should not be made: https://github.com/hashicorp/go-retryablehttp/blob/2bcd5fe0ec97e72d6402ebe273570b965166d226/client.go#L358-L361
I went looking for an example of that in the default implementation but it looks like its not being done?
https://github.com/hashicorp/go-retryablehttp/blob/2bcd5fe0ec97e72d6402ebe273570b965166d226/client.go#L462-L486
Is this just an oversight?
thanks
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.