hashicorp / hashicorp/go-retryablehttp

Feature request: give up early on 505, 506, 510, and 511

Open
#175 0 comments 3 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
2.3k
Forks
298
PR merge metrics
No merged PRs in 30d

Description

In addition to 501, these errors seem permanent as well:
```go
http.StatusHTTPVersionNotSupported // 505 HTTP Version Not Supported
http.StatusVariantAlsoNegotiates // 506 Variant Also Negotiates
http.StatusNotExtended // 510 Not Extended
http.StatusNetworkAuthenticationRequired // 511 Network Authentication Required
```
Perhaps we should skip the retry logic when we see one of them?

PS: I'm not sure about `http.StatusLoopDetected` (508 Loop Detected). Maybe we should include that as well.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.