hashicorp / hashicorp/go-retryablehttp

Do() should checks about CheckRetry value before calling it

Open
#108 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
2.3k
Forks
298
PR merge metrics
No merged PRs in 30d

Description

I have integrated go-retryablehttp but went into an issue on segfault when Do() function calls "CheckRetry".

That was because my code create the Client struct itself using:
`hc := &http.Client{}`

So all extra members of the Client object were not defined (like CheckRetry).

Switching to:
`hc := retryablehttp.NewClient()`
Fixed the issue.

So, I think the library should check "CheckRetry" value before calling it.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.