hashicorp / hashicorp/go-retryablehttp

Why DefaultRetryPolicy does not use OpError.Temporary()

Open
#103 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
2.3k
Forks
298
PR merge metrics
No merged PRs in 30d

Description

Hi,

Just reading the default retry implementation: https://github.com/hashicorp/go-retryablehttp/blob/master/client.go#L401 it doesn't seems to use any error check from the net package, especially the OpError: https://golang.org/pkg/net/#OpError with the Temporary() method. Do you think it would be a good idea to use it?

Thanks,

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.