hashicorp / hashicorp/go-plugin

Plugin client won't bootstrap successfully if the first message sent from plugin is not the negotiation format.

Open
#233 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
6.1k
Forks
511
Avg merge
22h 47m
Merged PRs (30d)
4

Description

I'm now using go-plugin to develop some Golang applications and it works well. Except that if the first message the client received from the plugin is not the right format like: 1|1|tcp|127.0.0.1:1234|grpc, the client will not correctly negotiate with the plugin process . This is a bit strict if some plugin written in Golang import other third party libs that print something in the init function.
![image](https://user-images.githubusercontent.com/122535561/212068537-36cbfadb-1351-4531-aa90-7b1b7b5a3152.png)
may be we could add some regex filter to extract the negotiate message from the plugin output? Or do we have better solution to deal with this problem?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.