hashicorp / hashicorp/go-plugin

client.Kill() should close connections in Test mode

Open
#215 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
6.1k
Forks
511
Avg merge
22h 47m
Merged PRs (30d)
4

Description

Hi,
For now, if plugin runs in test mode, client will not close its connections, because of this check, that `process == nil` runs early:
https://github.com/hashicorp/go-plugin/blob/master/client.go#L414

This can cause memory leaks in plugin.

Original issue in terraform-provider-aws:
https://github.com/hashicorp/terraform-provider-aws/issues/26130

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.