hashicorp / hashicorp/consul

Support new metadata format in Spring Cloud 2020.0.0 version

Open
#9,511 0 comments 0 reactions 0 assignees View on GitHub
theme/service-metadata type/enhancement
Dominant language
Go
Stars
30.1k
Forks
4.6k
Avg merge
2d 6h
Merged PRs (30d)
43

Description

For Spring Cloud 2020, it refactorys metadata logics. And we register some Spring configs as metadatas to Consul, like `spring.boot.version`. For Spring config, it often uses dot, so the issue will be
```
Caused by: com.ecwid.consul.v1.OperationException: OperationException(statusCode=400, statusMessage='Bad Request', statusContent='Invalid Service Meta: Couldn't load metadata pair ('spring.boot.version', '2.4.1'): Key contains invalid characters')
at com.ecwid.consul.v1.agent.AgentConsulClient.agentServiceRegister(AgentConsulClient.java:278)
at com.ecwid.consul.v1.ConsulClient.agentServiceRegister(ConsulClient.java:310)
```

I was surprised that dot will be a limitation with metadata key

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.