hashicorp / hashicorp/consul

inability to remember metrics

Open
#9,208 1 comment 0 reactions 0 assignees View on GitHub
theme/telemetry
Dominant language
Go
Stars
30.1k
Forks
4.6k
Avg merge
1d 18h
Merged PRs (30d)
39

Description

#### Overview of the Issue

Issue https://github.com/hashicorp/consul/issues/5140 was closed, on the basis that https://github.com/hashicorp/consul/pull/9198 addresses it.

Except, the issue https://github.com/hashicorp/consul/issues/5140 mentions two problems:
1. Only changed metrics are initialized on Consul start
(Which is addressed by https://github.com/hashicorp/consul/pull/9198)
2. After `prometheus_retention_time` expires they also get removed
(Which is not addressed.)

The change https://github.com/hashicorp/consul/pull/9198 will initialize metrics at startup, only to forget them once `prometheus_retention_time` expires.

Contributor guide

Open the contributing guide

Research direction

Start by reading issue #5140 and PR #9198, then trace the Go code handling prometheus_retention_time and metric lifecycle. Confirm the existing startup initialization behavior and identify where expiration removes metrics. Done means a regression test demonstrates the intended metric retention behavior after the retention period.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, prometheus
Domain
observability
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.