hashicorp / hashicorp/consul

Remove consul_consul from some metric namespaces

Open
#9,182 1 comment 0 reactions 0 assignees View on GitHub
theme/telemetry type/bug
Dominant language
Go
Stars
30.1k
Forks
4.6k
Avg merge
2d 6h
Merged PRs (30d)
43

Description

# Overview of the Issue

Some metrics in the `cache, fsm, and runtime` subcomponents emit write their namespace as `consul_consul...`. This is obviously wrong; as much as we love Consul we ought not name it twice where once will suffice!

#### Reproduction Steps

Start a connect-enabled 2-dc cluster on docker with https://github.com/mkeeler/consul-docker-test/tree/master/mesh-gateways-l7. The metrics can be queried for with `consul_consul` in prometheus' promql query runner.

### Operating system and Environment details

Linux, Docker

### Screenshots

View from inside the prometheus dashboard, querying for `consul_consul`
![Screen Shot 2020-11-12 at 4 49 56 PM](https://user-images.githubusercontent.com/938395/99015392-c2ea4b00-2509-11eb-997c-44c9624c1fac.png)
![Screen Shot 2020-11-12 at 4 50 18 PM](https://user-images.githubusercontent.com/938395/99015400-c5e53b80-2509-11eb-9c43-9e1a41ce79d3.png)
![Screen Shot 2020-11-12 at 4 50 25 PM](https://user-images.githubusercontent.com/938395/99015402-c7166880-2509-11eb-99b4-e0fef3ff2386.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.