hashicorp / hashicorp/consul

Configuring Exposed Checks for non-sidecar style proxies should not be allowed nor cause proxycfg errors

Open
#7,227 1 comment 0 reactions 0 assignees View on GitHub
theme/connect theme/operator-usability type/enhancement
Dominant language
Go
Stars
30.1k
Forks
4.6k
Avg merge
2d 6h
Merged PRs (30d)
43

Description

If you register a non-sidecar style proxy (the `DestinationServiceID` field is unset) then the proxycfg package will still attempt to start watches for exposed checks. These produce spurious errors in the logs.

Additionally we should probably add a validation where we validate the rest of the expose config to ensure that exposed checks being enabled are only allowed for a sidecar style proxy.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.