hashicorp / hashicorp/consul

unflake TestAgent_AddCheck_MissingService in CI

Open
#7,056 0 comments 0 reactions 0 assignees View on GitHub
theme/testing
Dominant language
Go
Stars
30.1k
Forks
4.6k
Avg merge
1d 18h
Merged PRs (30d)
39

Description

#### Overview of the Issue

https://github.com/hashicorp/consul/blob/ba8fd8296fe7c69615d0d27afdb2bbf71b6b32df/agent/agent_test.go#L1239

Did not fail locally in 1k runs, try with resource contention `make test-flake`

#### Reproduction Steps

Did not fail in 1k runs on local
`gotestsum --format short-verbose --jsonfile TestAgent_AddCheck_MissingService.json -- ./agent -run TestAgent_AddCheck_MissingService -count 1000`

### Operating system and Environment details

CircleCI, Mac OS X 10.14.6

### Log Fragments

CI: https://circleci.com/gh/hashicorp/consul/58322

Contributor guide

Open the contributing guide

Research direction

Start with TestAgent_AddCheck_MissingService in agent/agent_test.go around line 1239. Run the provided gotestsum command and try make test-flake to investigate behavior under resource contention, then compare with the linked CircleCI failure. Done means the test no longer flakes in CI or under the reported contention conditions.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
ci-cd, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.