hashicorp / hashicorp/consul

Fully validate configuration before reloading

Open
#6,041 1 comment 0 reactions 0 assignees View on GitHub
theme/operator-usability type/enhancement
Dominant language
Go
Stars
30.1k
Forks
4.6k
Avg merge
2d 6h
Merged PRs (30d)
43

Description

Currently when a config reload request is issued to an agent it will parse and do basic validation of the configuration. There are extra validation checks performed after this and after the previous local state(services, checks etc.) has been unloaded that can still fail and cause the agent to be left in a partially configured state.

Many of those extra checks are not runtime errors but could be validated against the static configuration.

#### Feature Description

Ensure that outside of random runtime issues that we cannot catch ahead of time (out of memory, network failures etc.) that a reload will not leave the Consul agent in an inconsistent state. This could involve creating a secondary state from the first and then swapping once we know the new state is okay or just moving many more of the validation checks to before things get unloaded.

#### Use Case(s)

When you want to reload an agents configuration.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.