hashicorp / hashicorp/consul

Output payload ignored in "critical" TTL update

Open
#5,389 1 comment 0 reactions 0 assignees View on GitHub
theme/health-checks type/enhancement
Dominant language
Go
Stars
30.1k
Forks
4.6k
Avg merge
1d 18h
Merged PRs (30d)
39

Description

Ouput payload silently ignored when passed in "critical" TTL update API call.
```
put "/agent/check/update/:check_id"
with payload:
{
"Status": "critical",
"Ouptu": "This is critical error"
}
```

Result with empty Output section in consul health checks UI. 'passing' and 'warning' works as expected in docs.

If there is previous update with ouput, then it will be displayed in "critical" check after TTL expired as:
```
TTL expired (last output before timeout follows): PREV PASSING OR WARN OUTPUT
```

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the request to PUT /agent/check/update/:check_id with a critical status and output payload, then compare it with passing and warning updates. Trace the TTL health-check update path and verify that the critical check preserves and displays the supplied output, including after TTL expiration.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.